Skip to Content [alt-c]
In reply to Comment by Reader Nuno
If you're using this on Linux, I advise doing away with the io.MultiReader. Just return the bytes.Buffer, and io.Copy both. net.TCPConn implements io.ReaderFrom using the splice(2) syscall, which makes this much more efficient (everything happens in kernel space).
A working patch:
--- sniproxy.go.orig 2022-10-17 10:28:24.851394840 +0000 +++ sniproxy.go 2022-10-17 10:30:02.661635510 +0000 @@ -57,7 +57,7 @@ if err != nil { return nil, nil, err } - return hello, io.MultiReader(peekedBytes, reader), nil + return hello, peekedBytes, nil }
type readOnlyConn struct { @@ -99,7 +99,7 @@ return }
- clientHello, clientReader, err := peekClientHello(clientConn) + clientHello, clientHelloBytes, err := peekClientHello(clientConn) if err != nil { log.Print(err) return @@ -131,7 +131,8 @@ wg.Done() }() go func() { - io.Copy(backendConn, clientReader) + io.Copy(backendConn, clientHelloBytes) + io.Copy(backendConn, clientConn) backendConn.(*net.TCPConn).CloseWrite() wg.Done() }()
Reply
Your comment will be public. To contact me privately, email me. Please keep your comment polite, on-topic, and comprehensible. Your comment may be held for moderation before being published.
Your Name: (Optional; will be published)
Your Email Address: (Optional; will not be published)
Your Website: (Optional; will be published)
>
monospaced
Post a Reply
Your comment will be public. To contact me privately, email me. Please keep your comment polite, on-topic, and comprehensible. Your comment may be held for moderation before being published.